Diablo 2 mods
 


Post new topic Reply to topic  [ 5 posts ] 
Author Message
PostPosted: Mon Jun 19, 2017 7:29 am 
 Post subject: Nihlathek Portal Fix#2
 
Offline
Champion of the Light
User avatar

Joined: Sat Mar 07, 2015 9:07 pm
Posts: 499
Gender: Male
Nilathek Portal fix that works... no multiple portals, you don't have to talk to Anya
It works flawless (as it should) before/after quest is finished.

[1.13d]

//JMP PATCH @ 0x1FF27

   JZ SHORT GOODEXIT
   MOV EAX,DWORD PTR[ESP+0x14]      // pPlayer @ esp+0x14
   PUSH EAX
   CALL NilPortalFix            // Quests_CheckFlag is quest complete ?
   TEST EAX,EAX
   JNZ SHORT GOODEXIT
   JMP D2GP_NilPortRetJmp2         // 0x1FFEC Quest not started skip portal flag

GOODEXIT:
   JMP D2GP_NilPortRetJmp1       // 0x1FF2D




Unfortunately I can't post Code for NilPortalFix "Call" because I'm not allowed.


Quote:
Forbidden

You don't have permission to access /forum/posting.php on this server.

Additionally, a 403 Forbidden error was encountered while trying to use an ErrorDocument to handle the request.

_________________
Pandemonium Quest 1.13d | Uber Tristram 1.13d
UVLoD | 1.13d Code Edits


Top
 Profile  
Reply with quote  
PostPosted: Sat Oct 14, 2017 6:12 am 
 Post subject: Re: Nihlathek Portal Fix#2
 
Offline
Crusader

Joined: Fri Apr 03, 2015 11:59 am
Posts: 52
Gender: None specified
[1.13c]

PATCH_JMP - 0x5AE67

__asm
{
   je Code1
   mov eax, [ESP+0x14]
   push eax
   call D2COMMON_QUESTS_CheckFlag     //#10174
   test eax, eax
   jnz Code1
   jmp Nihlathek_Portal_Fix_II     //0x5AF2C
Code1:
   jmp Nihlathek_Portal_Fix_I     //0x5AE6D
}



Top
 Profile  
Reply with quote  
PostPosted: Sat Oct 14, 2017 11:01 am 
 Post subject: Re: Nihlathek Portal Fix#2
 
Offline
Champion of the Light
User avatar

Joined: Sat Mar 07, 2015 9:07 pm
Posts: 499
Gender: Male
thaison wrote:
[1.13c]
PATCH_JMP - 0x5AE67
__asm
{
   je Code1
   mov eax, [ESP+0x14]
   push eax
   call D2COMMON_QUESTS_CheckFlag     //#10174
   test eax, eax
   jnz Code1
   jmp Nihlathek_Portal_Fix_II     //0x5AF2C
Code1:
   jmp Nihlathek_Portal_Fix_I     //0x5AE6D
}



Your code will crash... or fail. Quests_CheckFlags takes 3 arguments.

NilPortalFix expands pPlayer to get -> QuestFlag* pQuest.
From that it checks Quests_CheckFlags, if the Nihlathak quest reward is pending or quest completed ... function returns true or false.

_________________
Pandemonium Quest 1.13d | Uber Tristram 1.13d
UVLoD | 1.13d Code Edits


Top
 Profile  
Reply with quote  
PostPosted: Sat Oct 14, 2017 12:08 pm 
 Post subject: Re: Nihlathek Portal Fix#2
 
Offline
Crusader

Joined: Fri Apr 03, 2015 11:59 am
Posts: 52
Gender: None specified
devurandom wrote:
thaison wrote:
[1.13c]
PATCH_JMP - 0x5AE67
__asm
{
   je Code1
   mov eax, [ESP+0x14]
   push eax
   call D2COMMON_QUESTS_CheckFlag     //#10174
   test eax, eax
   jnz Code1
   jmp Nihlathek_Portal_Fix_II     //0x5AF2C
Code1:
   jmp Nihlathek_Portal_Fix_I     //0x5AE6D
}



Your code will crash... or fail. Quests_CheckFlags takes 3 arguments.

NilPortalFix expands pPlayer to get -> QuestFlag* pQuest.
From that it checks Quests_CheckFlags, if the Nihlathak quest reward is pending or quest completed ... function returns true or false.


I did on my mod, it works very well.

Image


Top
 Profile  
Reply with quote  
PostPosted: Sat Oct 14, 2017 8:19 pm 
 Post subject: Re: Nihlathek Portal Fix#2
 
Offline
Champion of the Light
User avatar

Joined: Sat Mar 07, 2015 9:07 pm
Posts: 499
Gender: Male
My code does not open the Nihlathak portal before the quest is started.
The portal remains open after Nihlathak quest is completed, or reward is pending.
Both conditions will close the portal in vanilla d2, if I recall correctly.

I haven't checked your code, but if it does all that correctly, then it's better than what I posted.

_________________
Pandemonium Quest 1.13d | Uber Tristram 1.13d
UVLoD | 1.13d Code Edits


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 


Who is online

Users browsing this forum: No registered users and 10 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group
Black Rock template by onyx (based on BlackSoul for phpBB2)