kill me pls 1.10 [solved]

[Aught]

i'm wasting my life trying to fix this


Sometimes i get random UE when click on "Trade" button of any NPC. I used backups of all my dlls but it didn't save me. Can this be because of txt editing?

Code: Select all

16:44:12.042  ***** UNHANDLED EXCEPTION: ACCESS_VIOLATION (c0000005)
16:44:12.042  Fault address:  6FC4EB49 01:0001DB49 J:\Diablo II\D2Game.dll
16:44:12.042  eax:00000001 ebx:00000001 ecx:00000000 edx:00000024 esi:043c2800
16:44:12.042  edi:0118e950 ebp:043a007c esp:0018e920 eip:6fc4eb49 flg:00010206
16:44:12.042  cs:0023 ds:002b es:002b ss:002b fs:0053 gs:002b

I followed 6FC4EB49 but couldn't understand what code there is.

Code: Select all

6FC4EB49    8B07            MOV EAX,DWORD PTR DS:[EDI]
6FC4EB4B    85C0            TEST EAX,EAX
6FC4EB4D    75 05           JNE SHORT D2Game.6FC4EB54
6FC4EB4F    83C8 FF         OR EAX,FFFFFFFF
6FC4EB52    EB 03           JMP SHORT D2Game.6FC4EB57
6FC4EB54    8B40 04         MOV EAX,DWORD PTR DS:[EAX+4]
6FC4EB57    50              PUSH EAX
6FC4EB58    E8 D1CB0C00     CALL <JMP.&D2Common.#10600>              ; Jump to D2Common.#10600
6FC4EB5D    85C0            TEST EAX,EAX
6FC4EB5F    74 74           JE SHORT D2Game.6FC4EBD5
6FC4EB61    8A88 2A010000   MOV CL,BYTE PTR DS:[EAX+12A]
6FC4EB67    84C9            TEST CL,CL
6FC4EB69    74 6A           JE SHORT D2Game.6FC4EBD5
6FC4EB6B    8A88 2B010000   MOV CL,BYTE PTR DS:[EAX+12B]
6FC4EB71    84C9            TEST CL,CL
6FC4EB73    74 60           JE SHORT D2Game.6FC4EBD5
6FC4EB75    8B07            MOV EAX,DWORD PTR DS:[EDI]
6FC4EB77    6A 40           PUSH 40
6FC4EB79    6A 00           PUSH 0
6FC4EB7B    50              PUSH EAX
6FC4EB7C    E8 87D00C00     CALL <JMP.&D2Common.#10483>              ; Jump to D2Common.#10483
6FC4EB81    8BF0            MOV ESI,EAX
6FC4EB83    85F6            TEST ESI,ESI
6FC4EB85    75 2F           JNE SHORT D2Game.6FC4EBB6
6FC4EB87    8B07            MOV EAX,DWORD PTR DS:[EDI]
6FC4EB89    85C0            TEST EAX,EAX
6FC4EB8B    75 05           JNE SHORT D2Game.6FC4EB92
6FC4EB8D    83C9 FF         OR ECX,FFFFFFFF
6FC4EB90    EB 03           JMP SHORT D2Game.6FC4EB95
6FC4EB92    8B48 0C         MOV ECX,DWORD PTR DS:[EAX+0C]
6FC4EB95    85C0            TEST EAX,EAX
6FC4EB97    74 03           JE SHORT D2Game.6FC4EB9C
6FC4EB99    8B40 08         MOV EAX,DWORD PTR DS:[EAX+8]
6FC4EB9C    51              PUSH ECX
6FC4EB9D    6A 04           PUSH 4
6FC4EB9F    6A 00           PUSH 0
6FC4EBA1    6A 40           PUSH 40
6FC4EBA3    50              PUSH EAX
6FC4EBA4    E8 59D00C00     CALL <JMP.&D2Common.#10470>              ; Jump to D2Common.#10470
6FC4EBA9    8B0F            MOV ECX,DWORD PTR DS:[EDI]
6FC4EBAB    8BF0            MOV ESI,EAX
6FC4EBAD    6A 01           PUSH 1
6FC4EBAF    56              PUSH ESI
6FC4EBB0    51              PUSH ECX
6FC4EBB1    E8 46D00C00     CALL <JMP.&D2Common.#10475>              ; Jump to D2Common.#10475
6FC4EBB6    33D2            XOR EDX,EDX
6FC4EBB8    6A 00           PUSH 0
6FC4EBBA    8A55 6D         MOV DL,BYTE PTR SS:[EBP+6D]
6FC4EBBD    52              PUSH EDX
6FC4EBBE    68 64010000     PUSH 164
6FC4EBC3    56              PUSH ESI
6FC4EBC4    E8 2DD00C00     CALL <JMP.&D2Common.#10465>              ; Jump to D2Common.#10465
6FC4EBC9    8B07            MOV EAX,DWORD PTR DS:[EDI]
6FC4EBCB    6A 01           PUSH 1
6FC4EBCD    6A 10           PUSH 10
6FC4EBCF    50              PUSH EAX
6FC4EBD0    E8 01CC0C00     CALL <JMP.&D2Common.#10708>              ; Jump to D2Common.#10708
6FC4EBD5    5F              POP EDI
6FC4EBD6    5E              POP ESI
6FC4EBD7    8BC3            MOV EAX,EBX
6FC4EBD9    5D              POP EBP
6FC4EBDA    5B              POP EBX
6FC4EBDB    83C4 08         ADD ESP,8
6FC4EBDE    C2 0800         RETN 8

Can anyone tell me something about this code?

EDIT: Also i'm sure it's not because of plugins, I work with them for a long time without any errors and conflicts. Crash has born a week ago while adding new items

[Necrolis]

Looks likely that its an invalid item*, this might be cause by blank or missing item codes (never, ever leave item code fields in armor/misc/weapons/gamble/runes/gems blank, use 'xxx' if you must have an empty value). Also, make sure you have not removed any of the hardcoded items such as bolts, arrows, keys, hp & mp pots.


*Note: I'm at work so I can't check the code to be sure

[Aught]

rechecked all x100 and used txt analyser, all is ok. And i didn't delete any default lod items. But found a bug with arrows and bolts that looks like wtf













EDIT: Ok, thing with multipling was fixed. But i found nothing about this crap with arrows and bolts. Automagics such as Artizan's and Jeweller's break only bolts and arrows.

[Eimernase]

Did you get this at any npc or such few or one?

Maybe check the items they can sell and also if you make any changings at those items.
If you cant found any mistakes at your txt-files, i would prefer take item after item you changed out and look again to find the crap.

[Aught]

I tried to fully restore game, client and common dlls, i tried to restore armor, misc, weapon and itemtypes txts but it didn't work. Checked all i could already.


EDIT: OK, it seems like a fixed this crap by restoring QualityItems.txt. Now, in the name of devil, can somebody tell me what's wrong with those file? Guide says new lines can be added. I checked all my lines there, all were perfect, no mistakes.

[kingpin]

you can't add new lines to qualityItems.txt as this file is heavily hardcoded.

[Aught]

Omg thanks Blizzard again. One more hardcoded.
If it's so, somebody plz fix this guide https://d2mods.info/index.php?ind=revie ... w&iden=437
because i really wasted a lot of time to find the reason of crash due to this.

EDIT: I forgot that automagics like Mechanics and Artizans still don't appear on arrows/bolts. Is it a bug of crappy blizzards code? It works perfectly, i even have RW's here, just wondering is there a way to make it show properly.

[kingpin]

Omg thanks Blizzard again. One more hardcoded.
If it's so, somebody plz fix this guide https://d2mods.info/index.php?ind=revie ... w&iden=437
because i really wasted a lot of time to find the reason of crash due to this.

EDIT: I forgot that automagics like Mechanics and Artizans still don't appear on arrows/bolts. Is it a bug of crappy blizzards code? It works perfectly, i even have RW's here, just wondering is there a way to make it show properly.

you should be aware that arrow/bolt is coded in different way compare to other equipments. I doubt arrow/bolt sockets even works (you could try add like +1 dex gem or similar) and see if your character get the bonus. If it works it's just a simple client fix to allow sockets be visible on it (it's same on rings as example).

[Aught]

hmmm, I tried this again and it works. O_o Gems and RW's works perfectly there. Hmm, hmm, it remains to find this simple fix in d2client